On Thu, Jul 26, 2012 at 8:20 PM, Borislav Petkov <b...@amd64.org> wrote: > > Ok, here's what I got from looking at the patch: > > Your commit message says: "Also request_firmware_nowait should be called > in atomic context now, so fix the obsolete comments." > > Atomic context in my book means you're not allowed to sleep at all.
In fact, I mean the function can be called in atomic context now, and I know some time ago the function will create kthread to execute the request_firmware, and atomic context is not allowed. So I remove the obsolete comment. > > But the comment says that it is possible to sleep a little. This is very > wrongly formulated AFAICT. The function can be run in both contexts, and I don't see any words which says the function will sleep. > > But, since request_firmware_nowait receives a GFP mask as one of its > arguments and some of its callers don't supply GFP_ATOMIC then this > has nothing to do with atomic contexts at all. Then, you should simply > explain in the comment why exactly callers aren't allowed to be sleeping > for a long time. And using adjectives like "long" or "short" is very > misleading in such explanations so please be more specific as to why the It is the original one, and I don't think it is wrong. Also it shouldn't be covered by this patch. Maybe I shouldn't have fixed the comment in this patch. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/