On Fri, Jul 27, 2012 at 11:52 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Fri, Jul 27, 2012 at 12:02:41PM +0800, Bryan Wu wrote: >> Send a uevent notification whenever a new sysfs file is created to allow >> userspace processes such as udev to modify permissions on the new files. > > This makes no sense, why not just call kobject_uevent after creating the > file when needed? Wrapping it up in a single function call doesn't add > any benefit that I can see, can you? >
I actually just want to make it benefit for further similar issue in other subsystem, although I got this point from the email started by Colin Cross. I agree if it is just specific to LED subsystem, we'd better add this fixing in LED trigger core code. Maybe I worried about too much and if you guys all ack Colin's patch, I'm going to apply it. Thanks, -Bryan >> >> This new API function helps to do this. >> >> Signed-off-by: Bryan Wu <bryan...@canonical.com> >> --- >> fs/sysfs/file.c | 28 ++++++++++++++++++++++++++++ >> include/linux/sysfs.h | 13 +++++++++++++ >> 2 files changed, 41 insertions(+) >> >> diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c >> index 00012e3..5a22d13 100644 >> --- a/fs/sysfs/file.c >> +++ b/fs/sysfs/file.c >> @@ -576,6 +576,34 @@ int sysfs_create_file(struct kobject * kobj, const >> struct attribute * attr) >> >> } >> >> +/** >> + * sysfs_create_file_uevent - create an attribute file for an object >> + and send a uevent to userspace. > > kerneldoc needs to be on one line for function names, right? > > greg k-h -- Bryan Wu <bryan...@canonical.com> Kernel Developer +86.186-168-78255 Mobile Canonical Ltd. www.canonical.com Ubuntu - Linux for human beings | www.ubuntu.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
