On 07/30/2012 01:51 PM, Kent Yoder wrote: > >>> Perhaps we should just do the same "err = total ? total : -EIO;" here >>> and the above statement can just turn into a break;. >> >> Yeah, this seems like the right thing to do. >> >>>> - ret = my_get_random(hash, SHA1_DIGEST_SIZE); >>>> + ret = tpm_get_random(TPM_ANY_NUM, hash, SHA1_DIGEST_SIZE); >>>> if (ret < 0) >>>> return ret; >>> >>> You are still not checking the return values correctly! >> >> Dave, can you weigh in on these individual cases? In some cases >> like capping a pcr I think using uninitialized stack data could be >> better than failing... > > I got in touch with Dave today, who'd like the full checking done now > that we can. Here's a new patch, let me know what you think... > > Thanks, > Kent >
Looks good to me. Reviewed-by: H. Peter Anvin <[email protected]> -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
