2012/8/3 Mark Brown <[email protected]>: > On Wed, Aug 01, 2012 at 12:08:08AM +0800, Axel Lin wrote: >> 於 二，2012-07-31 於 16:41 +0100，Mark Brown 提到： > >> > So the above cast probably isn't right... you shouldn't need a double >> > cast here. > >> The issue of original warning is: ( I compile the kernel on x86_64 ) >> warning: cast to pointer from integer of different size > >> What this patch does is: >> cast best_val to uintptr_t, which is an unsigned integer large enough to >> hold a void* pointer. > >> And then cast it to (void *). > >> Thus I did (void *)(uintptr_t)best_val. > > Perhaps we need a temporary variable here. The double cast just looks > too horrible.
Either is ok to me. But the double case looks better to me because the intention is clear. It seems uintptr_t is less commonly used in drivers code. Maybe just use (void *)(unsigned long)best_val is better in readability. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
