On Monday 06 August 2012, [email protected] wrote: > > From: Qiang Liu <[email protected]> > > The use of spin_lock_irqsave() is a stronger locking mechanism than is > required throughout the driver. The minimum locking required should be > used instead. Interrupts will be turned off and context will be saved, > there is needless to use irqsave. > > Change all instances of spin_lock_irqsave() to spin_lock_bh(). > All manipulation of protected fields is done using tasklet context or > weaker, which makes spin_lock_bh() the correct choice. > > Cc: Dan Williams <[email protected]> > Cc: Dan Williams <[email protected]> > Cc: Vinod Koul <[email protected]> > Cc: Li Yang <[email protected]> > Cc: Timur Tabi <[email protected]> > Signed-off-by: Qiang Liu <[email protected]> > Acked-by: Ira W. Snyder <[email protected]>
Acked-by: Arnd Bergmann <[email protected]> You could actually change the use of spin_lock_bh inside of the tasklet function (dma_do_tasklet) do just spin_lock(), because softirqs are already disabled there, but your version is also ok. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
