On Mon, 6 Aug 2012, Pavel Machek wrote:
> On Thu 2012-07-26 21:39:38, Len Brown wrote:
> > ...both give the number of chars in the string
> > without the '\0', as strncmp() wants,
> > but sizeof() is compile-time.
>
> What about introducing something like streq() to do this
> automatically? This is ugly....
>
> #define streq(a, b) ... if (_buildin_constant(b)) ...
>
> ?
>
> > - if (!strncmp(val, "enable", strlen("enable"))) {
> > + if (!strncmp(val, "enable", sizeof("enable") - 1)) {
While you're at it, there's no point using strncmp when you know the
length of one of the strings beforehand. Just use memcmp, and don't
subtract 1 from the sizeof value.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
