Hello Arnaldo, Thanks for comments, I will correct them. I need a bit more details about two of them.
2012/8/6 Arnaldo Carvalho de Melo <a...@ghostprotocols.net>: >> @@ -21,6 +23,9 @@ static int output; >> static u64 bytes_written; >> >> static bool inject_build_ids; >> +static bool inject_sched_stat; >> + >> +struct perf_session *session; perf_event__sched_stat (perf_inject.sample) uses "session" for getting an event name. I don't know how to get it by another way > > Why do we need to insert even more globals? > >> static int perf_event__repipe_synth(struct perf_tool *tool __used, >> union perf_event *event, >> @@ -47,7 +52,7 @@ static int perf_event__repipe_synth(struct perf_tool *tool >> __used, >> >> static int perf_event__repipe_op2_synth(struct perf_tool *tool, >> union perf_event *event, >> - struct perf_session *session __used) >> + struct perf_session *s __used) > > What is the point of the above hunk? "session" is global, for this reason I renamed all arguments. p.s. Arnaldo, sorry for the personal message with the same content. It's my mistake. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
