> -----Original Message----- > From: Guenter Roeck [mailto:[email protected]] > Sent: 06 August 2012 18:40 > To: Opensource [Anthony Olech] > Cc: Guenter Roeck; Jean Delvare; Randy Dunlop; Mark Brown; David Dajun > Chen; LKML; [email protected] > Subject: Re: [lm-sensors] [NEW DRIVER V2 6/7] DA9058 HWMON driver > On Sun, Aug 05, 2012 at 09:43:44PM +0100, Anthony Olech wrote: > > This is the HWMON component driver of the Dialog DA9058 PMIC. > > This driver is just one component of the whole DA9058 PMIC driver. > > It depends on the core DA9058 MFD driver. > > Signed-off-by: Anthony Olech <[email protected]> > > Signed-off-by: David Dajun Chen <[email protected]> > [ ... ] > > +static SENSOR_DEVICE_ATTR(vbat_mV, S_IRUGO, da9058_read_vbat, NULL, > > +0); static SENSOR_DEVICE_ATTR(adc_mV, S_IRUGO, > da9058_read_misc_channel, NULL, > > + DA9058_ADCMAN_MUXSEL_ADCIN); > > +static SENSOR_DEVICE_ATTR(vfpin_mV, S_IRUGO, da9058_read_vfpin, > NULL, > > +0); static SENSOR_DEVICE_ATTR(vfpin_mode, S_IRUGO, > da9058_vfpin_mode, > > +NULL, 0); static SENSOR_DEVICE_ATTR(tbat_mV, S_IRUGO, > > +da9058_read_tbat, NULL, 0); static SENSOR_DEVICE_ATTR(tjunc_in, > > +S_IRUGO, da9058_read_tjunc, NULL, 0); static > SENSOR_DEVICE_ATTR(adc_mode, S_IWUSR | S_IRUGO, > da9058_get_adc_mode, > > + da9058_set_adc_mode, 0); > Please use standard sysfs attribute names for temperature and voltage > attributes.
I could not find a naming convention, so I will try to abstract one from all the HWMON driver that have your name in them. I noted when searching that I missed out a file in also that Documentation/hwmon. I will correct both issues in my next submission attempt. > For configuration (XXX_mode), please use devicetreee and/or platform data, > not sysfs attributes. As far as I can see both devicetreee and platform data allow configuration data to be passed into the driver at "probe" time, they don't allow an operating mode to be changed dynamically. That is what I thought sysfs allowed. Thus your comments seem to imply that you do not want to allow the mode to be changed dynamically. If that is the case then I can remove the dynamic mode setting, leaving it fixed by platform data. Thanks, Tony Olech -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
