On Wed, Aug 8, 2012 at 11:19 AM, Arnd Bergmann <[email protected]> wrote:
>> What on earth are all those magic numbers?
>>
>> I *guess* they're enabling some default GPIO settings etc.
>
> No, they are the register offsets you quoted above, per bank.
Aha I was fooled by this:
+struct vt8500_gpio_bank_regs {
+ int en;
+ int dir;
+ int data_out;
+ int data_in;
+ int ngpio;
+};
This needs to be named something intuitive like "vt8500_gpio_bank_regoffsets"
Some kerneldoc intsead of the opaque comment above will also improve
readability a lot:
/**
* struct vt8500_gpio_bank_regoffsets
* @en: offset to enable register in the bank
* ...
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
