On 08/08/12 07:47, Arnd Bergmann wrote: > The init_cpu_topology function can be put into the __init section > and discarded after boot, because it is only called from > smp_prepare_cpus, which is also marked __init. This was reported > by gcc after Vincent Guittot added the parse_dt_topology function > in 339ca09d7ada "ARM: 7463/1: topology: Update cpu_power according to DT > information". > > Without this patch, building kzm9g_defconfig results in: > > WARNING: vmlinux.o(.text+0xb5a0): Section mismatch in reference from the > function init_cpu_topology() to the function .init.text:parse_dt_topology() > The function init_cpu_topology() references > the function __init parse_dt_topology(). > This is often because init_cpu_topology lacks a __init > annotation or the annotation of parse_dt_topology is wrong. > > Signed-off-by: Arnd Bergmann <[email protected]> > Cc: Vincent Guittot <[email protected]> > Cc: Namhyung Kim <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: Russell King <[email protected]> > ---
This is already in the patch tracker http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7482/1 I also notice that store_cpu_topology() should be marked __cpuinit and update_siblings_mask, middle_capacity, cpu_capacity, and update_cpu_power should be static. We should probably also rename update_cpu_power() so as to not conflict with the one in kernel/sched/fair.c -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
