On 8 August 2012 20:17, Arnd Bergmann <[email protected]> wrote: > When a device tree definition os an s3c64xx SPI master is missing > a "controller-data" subnode, the newly added s3c64xx_get_slave_ctrldata > function might use uninitialized memory in place of that node, > which was correctly reported by gcc. > > Without this patch, building s3c6400_defconfig results in: > > drivers/spi/spi-s3c64xx.c: In function 's3c64xx_get_slave_ctrldata.isra.25': > drivers/spi/spi-s3c64xx.c:841:5: warning: 'data_np' may be used uninitialized > in this function [-Wuninitialized] > > Signed-off-by: Arnd Bergmann <[email protected]> > Cc: Thomas Abraham <[email protected]> > Cc: Jaswinder Singh <[email protected]> > Cc: Grant Likely <[email protected]> > Cc: Kukjin Kim <[email protected]> > --- > drivers/spi/spi-s3c64xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 646a765..cfa2c35 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -826,7 +826,7 @@ static struct s3c64xx_spi_csinfo > *s3c64xx_get_slave_ctrldata( > struct spi_device *spi) > { > struct s3c64xx_spi_csinfo *cs; > - struct device_node *slave_np, *data_np; > + struct device_node *slave_np, *data_np = NULL; > u32 fb_delay = 0; > > slave_np = spi->dev.of_node; > -- > 1.7.10 >
Acked-by: Thomas Abraham <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
