On Tue, Aug 14, 2012 at 11:24:01PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 14, 2012 at 05:08:31PM -0300, Rafael Aquini wrote: > > On Tue, Aug 14, 2012 at 10:59:16PM +0300, Michael S. Tsirkin wrote: > > > > > > What if there is more than one balloon device? > > > > > > > > > > Is it possible to load this driver twice, or are you foreseeing a > > > > > future case > > > > > where this driver will be able to manage several distinct memory > > > > > balloons for > > > > > the same guest? > > > > > > > > > > > > > Second. > > > > It is easy to create several balloons they are just > > > > pci devices. > > > > > > > > > > > > and it might not be too important to make it work but > > > at least would be nice not to have a crash in this > > > setup. > > > > > Fair enough. For now, as I believe it's safe to assume we are only > > inflating one > > balloon per guest, I'd like to propose this as a future enhancement. Sounds > > good? > > > > Since guest crashes when it's not the case, no it doesn't, sorry :(. > Ok, but right now this driver only takes care of 1 balloon per guest, so how could this approach crash it?
Your point is a good thing to be on a to-do list for future enhancements, but it's not a dealbreaker for the present balloon driver implementation, IMHO. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
