Hi,

This one is a bit denser, so just a quick first pass with a couple of minor
comments. I'll revisit the rest.

On Tue, Aug 14, 2012 at 06:52:04PM +0100, Catalin Marinas wrote:

> +el1_sp_pc:
> +     /*
> +      *Stack or PC alignment exception handling
> +      */
> +     mrs     x0, far_el1
> +     mov     x1, x25
> +     mov     x2, sp
> +     b       do_sp_pc_abort
> +el1_undef:
> +     /*
> +      *Undefined instruction
> +      */

Nit: Missing spaces in the comment here and the one above.

> +el0_undef:
> +     /*
> +      *Undefined instruction
> +      */
> +     mov     x0, sp
> +     b       do_undefinstr

Here too.

> diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
> new file mode 100644
> index 0000000..8712a8e
> --- /dev/null
> +++ b/arch/arm64/kernel/traps.c
[...]
> +DEFINE_SPINLOCK(die_lock);

Should probably be static.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to