On Mon, 20 Aug 2012 10:55:24 +0900, Namhyung Kim wrote: > On Mon, 20 Aug 2012 10:50:21 +0900, Namhyung Kim wrote: >> On Sat, 18 Aug 2012 10:52:03 +0300, Pekka Enberg wrote: >>> Wouldn't it be nicer to rearrange the callers so that perf_gtk__exit() >>> is not called twice? >> >> You mean this? >> >> >> diff --git a/tools/perf/ui/setup.c b/tools/perf/ui/setup.c >> index c7820e569660..d25e145e9a89 100644 >> --- a/tools/perf/ui/setup.c >> +++ b/tools/perf/ui/setup.c >> @@ -2,6 +2,7 @@ >> >> #include "../cache.h" >> #include "../debug.h" >> +#include "gtk/gtk.h" > > Oops, it should be > > #ifndef NO_GTK2_SUPPORT > # include "gtk/gtk.h" > #endif >
Forgot to add the #ifdefery to the below code also. :-/ Anyway, it needs to expose gtk specifics to general code with the #ifdef's. So I'd still prefer the original patch. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
