On Wed, 15 Aug 2012 21:43:06 +0300, Dmitry Kasatkin <dmitry.kasat...@intel.com>
wrote:
> + } else {
> + struct {
> + struct shash_desc shash;
> + char ctx[crypto_shash_descsize(tfm)];
> + } desc;
Linus had a rant a while ago about using variable-sized stack vars in
the kernel (can't find a reference right now, sorry).
The problem is that either you know there's a limit to
crypto_shash_descsize(), in which case you can just use this here, or
you don't know, in which case, this risks a stack oveflow.
Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
