On Thu, 16 Aug 2012, Tejun Heo wrote: > On Thu, Aug 16, 2012 at 01:44:54PM -0400, a...@redhat.com wrote: > > From: Li Zefan <lize...@huawei.com> > > > > Extract in-memory xattr APIs from tmpfs. Will be used by cgroup. > > > > $ size vmlinux.o > > text data bss dec hex filename > > 4658782 880729 5195032 10734543 a3cbcf vmlinux.o > > $ size vmlinux.o > > text data bss dec hex filename > > 4658957 880729 5195032 10734718 a3cc7e vmlinux.o > > > > v6: > > - no changes > > v5: > > - no changes > > v4: > > - move simple_xattrs_free() to fs/xattr.c > > v3: > > - in kmem_xattrs_free(), reinitialize the list > > - use simple_xattr_* prefix > > - introduce simple_xattr_add() to prevent direct list usage > > > > Cc: Li Zefan <lize...@huawei.com> > > Cc: Tejun Heo <t...@kernel.org> > > Cc: Hugh Dickins <hu...@google.com> > > Hugh, can you please review and ack this one?
Yes, it looks nice to me. I might have preferred more as inlines in the header file to lower the slight init/evict overhead, and I don't see why __simple_xattr_set() isn't using simple_xattr_alloc() in the same way that shmem_xattr_set() used shmem_xattr_alloc(). But none of that matters: Acked-by: Hugh Dickins <hu...@google.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
