On Mon, Aug 27, 2012 at 04:09:46PM -0700, Linus Walleij wrote: > On Mon, Aug 20, 2012 at 4:59 AM, Lee Jones <[email protected]> wrote: > > On Tue, Aug 14, 2012 at 10:51:02AM +0200, Linus Walleij wrote: > > >> But wait. These are just local statics. Surelty you can put these into > >> struct ux500_msp instead? Here it looks like these will be used for > >> all ports, so MSP2 will enable the pins requested by MSP1 etc > >> completely broken. So put it into the struct ux500_msp state > >> container from ux500_msp_i2s.h where it belongs. > >> > >> Refer to drivers/tty/serial/amba-pl011.c when in trouble. This > >> one is a good pinctrl example. > > > > How do you see the MSP1 and MSP3 usage protection working if I hide it > > all away in MSP specific structs? > > Usage protection? Sorry not following. Please elaborate...
Don't worry about it, I think I sorted it. Please see the lastest version of the patch (sent on 24th Aug). -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
