On Thu, Aug 30, 2012 at 02:35:36PM -0700, Paul E. McKenney wrote: > On Thu, Aug 30, 2012 at 11:57:05AM -0700, Josh Triplett wrote: > > On Thu, Aug 30, 2012 at 11:45:08AM -0700, Paul E. McKenney wrote: > > > From: "Paul E. McKenney" <[email protected]> > > > > > > A number of new features have been added to rcutorture over the years, but > > > the defaults have not been updated to include them. This commit therefore > > > turns on a couple of them that have proven helpful and trustworthy, namely > > > periodic progress reports and testing of NO_HZ. > > > > > > Signed-off-by: Paul E. McKenney <[email protected]> > > > Signed-off-by: Paul E. McKenney <[email protected]> > > > --- > > > kernel/rcutorture.c | 4 ++-- > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c > > > index 25b1503..86315d3 100644 > > > --- a/kernel/rcutorture.c > > > +++ b/kernel/rcutorture.c > > > @@ -53,10 +53,10 @@ MODULE_AUTHOR("Paul E. McKenney <[email protected]> > > > and Josh Triplett <josh@fre > > > > > > static int nreaders = -1; /* # reader threads, defaults to > > > 2*ncpus */ > > > static int nfakewriters = 4; /* # fake writer threads */ > > > -static int stat_interval; /* Interval between stats, in seconds. > > > */ > > > +static int stat_interval = 60; /* Interval between stats, in seconds. > > > */ > > > /* Defaults to "only at end of test". */ > > > > Need to remove this comment about the default. > > Good catch! I have replaced it with "Zero means "only at end of test".
Good point, you definitely still need to document what zero means. > > > static bool verbose; /* Print more debug info. */ > > > -static bool test_no_idle_hz; /* Test RCU's support for tickless idle > > > CPUs. */ > > > +static bool test_no_idle_hz = 1; /* Test RCU support for tickless idle > > > CPUs. */ > > > > s/1/true/ > > Good point, fixed. > > Thank you for looking this over! With those two fixes: Reviewed-by: Josh Triplett <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
