On Wed, Sep 05 2012, Minchan Kim wrote: > This patch introudes MIGRATE_DISCARD mode in migration. > It drops *clean cache pages* instead of migration so that > migration latency could be reduced by avoiding (memcpy + page remapping). > It's useful for CMA because latency of migration is very important rather > than eviction of background processes's workingset. In addition, it needs > less free pages for migration targets so it could avoid memory reclaiming > to get free pages, which is another factor increase latency. > > Cc: Marek Szyprowski <[email protected]> > Cc: Michal Nazarewicz <[email protected]> > Cc: Rik van Riel <[email protected]> > Cc: Mel Gorman <[email protected]> > Signed-off-by: Minchan Kim <[email protected]>
The principle is very good (I always intended for CMA to discard clean pages but simply did not have time to implement it), and the code looks reasonably good to me. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: [email protected]>--------------ooO--(_)--Ooo--
pgp5ySj9CeL89.pgp
Description: PGP signature
