On 09/06/2012 01:27 AM, Ben Hutchings : > On Wed, 2012-09-05 at 11:00 +0200, Nicolas Ferre wrote: >> Add an indication about which revision of the hardware we are running in >> info->driver string. >> >> Signed-off-by: Nicolas Ferre <[email protected]> >> --- >> drivers/net/ethernet/cadence/macb.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/ethernet/cadence/macb.c >> b/drivers/net/ethernet/cadence/macb.c >> index bd331fd..c7c39f1 100644 >> --- a/drivers/net/ethernet/cadence/macb.c >> +++ b/drivers/net/ethernet/cadence/macb.c >> @@ -1313,6 +1313,10 @@ static void macb_get_drvinfo(struct net_device *dev, >> struct macb *bp = netdev_priv(dev); >> >> strcpy(info->driver, bp->pdev->dev.driver->name); >> + if (macb_is_gem(bp)) >> + strcat(info->driver, " GEM"); >> + else >> + strcat(info->driver, " MACB"); >> strcpy(info->version, "$Revision: 1.14 $"); > > Related to hardware revisions (which don't belong here, as David said), > I rather doubt this CVS ID is very useful as a driver version. > > If the driver doesn't have a meaningful version (aside from the kernel > version) then you can remove this function and let the ethtool core fill > in the other two fields automatically.
Absolutely, I will do this. Thanks for the tip. Best regards, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
