On Wed, 2012-09-12 at 09:29 -0300, Ezequiel Garcia wrote: > Steven, > > On Tue, Sep 11, 2012 at 9:34 PM, Steven Rostedt <[email protected]> wrote: > ble(void) > [...] > >> + /* > >> + * Early initialization already enabled ftrace event. > >> + * Now it's only necessary to create the event directory. > >> + */ > >> for_each_event(call, __start_ftrace_events, __stop_ftrace_events) { > >> - __trace_add_event_call(*call, NULL, &ftrace_event_id_fops, > > > > Here, __trace_add_event_call() did the checks and did not create a > > directory on raw_init() failure. But now there's no check, and we are > > having events being created that should not be. > > > > I believe the problem is we're iterating through every event > defined in __start_ftrace_events. > We should iterate through the events added to the ftrace_events list.
Yeah, that sounds like a better solution. I can't at the moment think of anything where that would break. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
