On Fri, Sep 14, 2012 at 01:55:55PM -0700, Tejun Heo wrote: > On Fri, Sep 14, 2012 at 01:54:34PM -0700, Tejun Heo wrote: > > On Fri, Sep 14, 2012 at 09:35:54PM +0200, Sasha Levin wrote: > > > Prevent warnings generated by smatch due to unchecked dereference of > > > 'new_xattr' in __simple_xattr_set(). > > > > Isn't this an actual bug w/ or w/o smatch? Remove request (NULL > > @value) w/o XATTR_REPLACE for an non-existent node would end up > > calling list_add() on NULL, right? If so, please collapse these two > > patches and mention the actual bug instead of smatch warning. > > And can somebody please make that function less confusing? - > restructuring / commenting whatever. It's doing something simple. > It's not supposed to be this confusing.
I'll work on that. -- Aristeu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
