On 17/09/12 23:58, Shubhrajyoti D wrote: > Convert the struct i2c_msg initialization to C99 format. This makes > maintaining and editing the code simpler. Also helps once other fields > like transferred are added in future. > > Signed-off-by: Shubhrajyoti D <[email protected]> > --- > drivers/rtc/rtc-isl1208.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c > index dd2aeee..c3a76ae 100644 > --- a/drivers/rtc/rtc-isl1208.c > +++ b/drivers/rtc/rtc-isl1208.c > @@ -68,9 +68,9 @@ isl1208_i2c_read_regs(struct i2c_client *client, u8 reg, u8 > buf[], > { > u8 reg_addr[1] = { reg }; > struct i2c_msg msgs[2] = { > - {client->addr, 0, sizeof(reg_addr), reg_addr} > + {.addr = client->addr, .flags = 0, .len = sizeof(reg_addr), > .buf = reg_addr} > ,
Putting the whole initialiser on one line is a bit ugly. Any reason not to expand it over multiple lines as the previous patch (and majority of other drivers) does? ~Ryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
