On Tue, Sep 18, 2012 at 08:37:07AM -0500, Rob Herring wrote: > On 09/18/2012 03:57 AM, Thierry Reding wrote: [...] > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-adnp.txt > > b/Documentation/devicetree/bindings/gpio/gpio-adnp.txt > > new file mode 100644 > > index 0000000..5a09a21 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/gpio-adnp.txt > > @@ -0,0 +1,30 @@ > > +Avionic Design N-bit GPIO expander bindings > > + > > +Required properties: > > +- compatible: should be "ad,gpio-adnp" > > +- reg: The I2C slave address for this device. > > +- interrupt-parent: phandle of the parent interrupt controller. > > +- interrupts: Interrupt specifier for the controllers interrupt. > > +- #gpio-cells: Should be 2. The first cell is the GPIO number and the > > + second cell is used to specify optional parameters: > > + - bit 0: polarity (0: normal, 1: inverted) > > This contradicts the documentation changes you just submitted. That's > fine, but perhaps that documentation should say recommended encoding of > cells unless defined differently for an individual binding.
The documentation changes were for #interrupt-cells, this is #gpio-cells. Thierry
pgpycKUZk089h.pgp
Description: PGP signature
