On Tue, 2012-09-18 at 17:36 -0600, Jim Cromie wrote: > dynamic_emit_prefix() currently separates modname, funcname, lineno > with ':'. This is confounds use of cut -d: <logfile>, since the field > positions can change per callsite with dynamic-debug. So change > inter-field separator to '.' and keep the ':' prefix terminator. > > This improves the situation, but doesnt solve it entirely; if > dyndbg==p is used instead of dyndbg==p[fmlt]+, the callsite is enabled > but no prefix is added, so theres one less ':' in the message. > Changing the terminator to ',' would fix this, and might be warranted, > especially since pr_fmt() typically adds a ':' as well. > > Joe Perches wasnt a fan of this, but his complaint was essentially > that cut -d: was a poor way to do this kind of thing. I concede that > point, but note that the kernel is not in the habit of needlessly > confounding users work, at least when accommodating them is so trivial.
And I still think this is ugly as it requires different parsing by scripts when using combinations of +pfmlt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
