(2012/09/19 22:46), Borislav Petkov wrote: > From: Borislav Petkov <borislav.pet...@amd.com> > > I get > > arch/x86/kernel/kprobes.c:544:23: warning: ‘skip_singlestep’ declared > ‘static’ but never defined [-Wunused-function] > > on tip/auto-latest. > > Hide the forward declaration in the KPROBES_CAN_USE_FTRACE as it > is done in its callsites.
Thank you for reporting and fixing :) Acked-by: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> Ingo, please pull this. Thank you, > > Cc: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> > Cc: Steven Rostedt <rost...@goodmis.org> > Signed-off-by: Borislav Petkov <borislav.pet...@amd.com> > --- > arch/x86/kernel/kprobes.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c > index b7c2a85d1926..ac4188368fdf 100644 > --- a/arch/x86/kernel/kprobes.c > +++ b/arch/x86/kernel/kprobes.c > @@ -541,8 +541,11 @@ reenter_kprobe(struct kprobe *p, struct pt_regs *regs, > struct kprobe_ctlblk *kcb > return 1; > } > > +#ifdef KPROBES_CAN_USE_FTRACE > static void __kprobes skip_singlestep(struct kprobe *p, struct pt_regs *regs, > struct kprobe_ctlblk *kcb); > +#endif > + > /* > * Interrupts are disabled on entry as trap3 is an interrupt gate and they > * remain disabled throughout this function. > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu...@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/