On Thu, Sep 20, 2012 at 04:56:43PM -0700, Tejun Heo wrote: > On Mon, Sep 10, 2012 at 05:22:21PM -0700, Kent Overstreet wrote: > > Random cleanup - this code was duplicated and it's not really specific > > to md. > > > > Also added the ability to return the actual error code. > > > > Signed-off-by: Kent Overstreet <koverstr...@google.com> > > CC: Jens Axboe <ax...@kernel.dk> > > CC: NeilBrown <ne...@suse.de> > > Acked-by: Tejun Heo <t...@kernel.org> > > > --- a/include/linux/bio.h > > +++ b/include/linux/bio.h > > @@ -249,6 +249,7 @@ extern void bio_endio(struct bio *, int); > > struct request_queue; > > extern int bio_phys_segments(struct request_queue *, struct bio *); > > > > +extern int submit_bio_wait(int rw, struct bio *bio); > > void bio_advance(struct bio *, unsigned); > > Heh, this is one of the reasons why I don't like extern on function > prototypes. It's not necessary and people end up jumping between the > two forms. :(
Yeah, I dislike it too but I was trying to follow the style in that file - I did fix bio_advance() a few minutes ago. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
