On Fri, Sep 21, 2012 at 11:29:56AM +0800, Zhenzhong Duan wrote: > pages_to_unuse is set to 0 to unuse all frontswap pages > But that doesn't happen since a wrong condition in frontswap_shrink > cancels it. > > Signed-off-by: Zhenzhong Duan <[email protected]> > --- > mm/frontswap.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/frontswap.c b/mm/frontswap.c > index 6b3e71a..db2a86f 100644 > --- a/mm/frontswap.c > +++ b/mm/frontswap.c > @@ -275,7 +275,7 @@ static int __frontswap_shrink(unsigned long target_pages, > if (total_pages <= target_pages) { > /* Nothing to do */ > *pages_to_unuse = 0; > - return 0; > + return 1; > }
This function used to return 0 or an error code. Could we add a comment at the top saying what the return values mean. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
