Hi.
On 09/06/2012 10:38 AM, Peter Senna Tschudin wrote:
> From: Peter Senna Tschudin <peter.se...@gmail.com>
>
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
>
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.se...@gmail.com>
Acked-by: Tomasz Stanislawski <t.stanisl...@samsung.com>
>
> ---
> drivers/media/platform/s5p-tv/sdo_drv.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/s5p-tv/sdo_drv.c
> b/drivers/media/platform/s5p-tv/sdo_drv.c
> index ad68bbe..58cf56d 100644
> --- a/drivers/media/platform/s5p-tv/sdo_drv.c
> +++ b/drivers/media/platform/s5p-tv/sdo_drv.c
> @@ -369,6 +369,7 @@ static int __devinit sdo_probe(struct platform_device
> *pdev)
> sdev->fout_vpll = clk_get(dev, "fout_vpll");
> if (IS_ERR_OR_NULL(sdev->fout_vpll)) {
> dev_err(dev, "failed to get clock 'fout_vpll'\n");
> + ret = -ENXIO;
> goto fail_dacphy;
> }
> dev_info(dev, "fout_vpll.rate = %lu\n", clk_get_rate(sclk_vpll));
> @@ -377,11 +378,13 @@ static int __devinit sdo_probe(struct platform_device
> *pdev)
> sdev->vdac = devm_regulator_get(dev, "vdd33a_dac");
> if (IS_ERR_OR_NULL(sdev->vdac)) {
> dev_err(dev, "failed to get regulator 'vdac'\n");
> + ret = -ENXIO;
> goto fail_fout_vpll;
> }
> sdev->vdet = devm_regulator_get(dev, "vdet");
> if (IS_ERR_OR_NULL(sdev->vdet)) {
> dev_err(dev, "failed to get regulator 'vdet'\n");
> + ret = -ENXIO;
> goto fail_fout_vpll;
> }
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
