On Mon, 24 Sep 2012 23:24:10 +0800, Feng Tang wrote:
[snip]
> + if (!check_perf_magic(magic)) {
> + options[nr_options] = strdup(name);
> + abs_path[nr_options++] = strdup(path);
Need to check return values.
> + }
> + fclose(file);
> + }
> + closedir(pwd_dir);
> +
> + if (nr_options) {
> + choice = ui__popup_menu(nr_options, options);
> + if (choice < nr_options && choice >= 0) {
> + input_name = strdup(abs_path[choice]);
Ditto. Plus it might leak previous input_name.
Thanks,
Namhyung
> + ret = 0;
> + }
> + }
> +
> + free_popup_options(options, nr_options);
> + free_popup_options(abs_path, nr_options);
> + return ret;
> +}
> +
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
