On Thu, Sep 27, 2012 at 3:31 PM, Vinod Koul <[email protected]> wrote: > Let me try again. > > what does it take to do platform and PCI driver for this: > 1. make dma h/w access (read/write) platform independent. which you have > already done > 2. Device registration: Create two probes, or use common probe. > You smartly chose the second one BUT by creating another device. > If you look closely at the probe then I would say it would be easy to > create library for probe which can be used across both pci and platform > driver probes. The probe library which initializes driver and registers > with dmaengine needs device struct and resources can be provided by each > probe.
Or in other words... create three files - dw_dmac.c - dw_dmac-pltfm.c - dw_dmac-pci.c... Don't do anything specific to platform or pci in dw_dmac.c... Keep pltfm and pci files to smallest possible size, and keep as much of common part in dmac.c... Similar is done in drivers/mmc/host/sdhci*... This is what i was thinking when i questioned multiple device creation... -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
