> -----Original Message----- > From: Sachin Kamat [mailto:[email protected]] > Sent: Thursday, September 27, 2012 4:28 PM > To: [email protected] > Cc: R, Durgadoss; Zhang, Rui; [email protected]; [email protected] > Subject: [PATCH] thermal: step_wise: Add missing static storage class > specifiers > > Fixes the following sparse warnings: > drivers/thermal/step_wise.c:153:5: warning: > symbol 'step_wise_throttle' was not declared. Should it be static? > drivers/thermal/step_wise.c:172:25: warning: > symbol 'thermal_gov_step_wise' was not declared. Should it be static?
Looks fine. Acked-by: Durgadoss R <[email protected]> Care to fix the same things in fair_share.c and user_space.c ? Thanks, Durga > > Signed-off-by: Sachin Kamat <[email protected]> > --- > drivers/thermal/step_wise.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c > index 3f9cfcf..1242cff 100644 > --- a/drivers/thermal/step_wise.c > +++ b/drivers/thermal/step_wise.c > @@ -150,7 +150,7 @@ static void thermal_zone_trip_update(struct > thermal_zone_device *tz, int trip) > * step. If the zone is 'cooling down' it brings back the performance of > * the devices by one step. > */ > -int step_wise_throttle(struct thermal_zone_device *tz, int trip) > +static int step_wise_throttle(struct thermal_zone_device *tz, int trip) > { > struct thermal_instance *instance; > > @@ -169,7 +169,7 @@ int step_wise_throttle(struct thermal_zone_device > *tz, int trip) > return 0; > } > > -struct thermal_governor thermal_gov_step_wise = { > +static struct thermal_governor thermal_gov_step_wise = { > .name = DEFAULT_THERMAL_GOVERNOR, > .throttle = step_wise_throttle, > .owner = THIS_MODULE, > -- > 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
