> -----Original Message----- > From: Sachin Kamat [mailto:[email protected]] > Sent: Thursday, September 27, 2012 4:58 PM > To: [email protected] > Cc: R, Durgadoss; Zhang, Rui; [email protected]; [email protected] > Subject: [PATCH 2/2] thermal: user_space: Add missing static storage class > specifiers > > Fixes the following sparse warnings: > drivers/thermal/user_space.c:38:5: warning: > symbol 'notify_user_space' was not declared. Should it be static? > drivers/thermal/user_space.c:46:25: warning: > symbol 'thermal_gov_user_space' was not declared. Should it be static?
Looks fine. Thanks for the two patches :-) Acked-by: Durgadoss R <[email protected]> Thanks, Durga > > Signed-off-by: Sachin Kamat <[email protected]> > --- > drivers/thermal/user_space.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/user_space.c b/drivers/thermal/user_space.c > index fb246b90..6bbb380 100644 > --- a/drivers/thermal/user_space.c > +++ b/drivers/thermal/user_space.c > @@ -35,7 +35,7 @@ > * > * This function notifies the user space through UEvents. > */ > -int notify_user_space(struct thermal_zone_device *tz, int trip) > +static int notify_user_space(struct thermal_zone_device *tz, int trip) > { > mutex_lock(&tz->lock); > kobject_uevent(&tz->device.kobj, KOBJ_CHANGE); > @@ -43,7 +43,7 @@ int notify_user_space(struct thermal_zone_device *tz, > int trip) > return 0; > } > > -struct thermal_governor thermal_gov_user_space = { > +static struct thermal_governor thermal_gov_user_space = { > .name = "user_space", > .throttle = notify_user_space, > .owner = THIS_MODULE, > -- > 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
