On Fri, Sep 28, 2012 at 07:40:39PM -0400, Ramesh Nagappa wrote: > >From fd023edd911ef12aca38a72b40241661c202684f Mon Sep 17 00:00:00 2001 > From: Ramesh Nagappa <[email protected]> > Date: Thu, 27 Sep 2012 10:20:58 -0700 > Subject: [PATCH] net: fix neigh_resolve_output can cause skb_under_panic
Why is all of this in the middle of the changelog section? I'm guessing you didn't use 'git send-email' for this? And why are you copying me on the patch? > The retry loop in the neigh_resolve_output() and neigh_connected_output() can > add > a hard_header without resetting the skb to network header. This causes the > skb_push() in dev_hard_header() to fail. > Signed-off-by: Ramesh Nagappa <[email protected]> > Signed-off-by: Shawn Lu <[email protected]> > Reviewed-by: Billie Alsup <[email protected]> > Reviewed-by: Robert Coulson <[email protected]> You need a blank line before the first Signed-off-by: line. Surely one of the reviewers should have caught this basic thing? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
