On Mon, 2012-10-01 at 19:31 +0200, Jiri Olsa wrote:
> @@ -696,7 +696,7 @@ struct perf_branch_stack {
>
> struct perf_regs_user {
> __u64 abi;
> - struct pt_regs *regs;
> + struct pt_regs regs;
> };
That's somewhat unfortunate but unavoidable I guess, can't go modify pt_regs.
> + if (uregs->abi)
> + stack_size =
> perf_sample_ustack_size(sample_stack_user,
> + header->size,
> +
just a style nit, please add {} for all multi-line single stmt
constructs like that, even though not strictly required.
It reduces the possible confusion between multi-line and multi-statement
and reads easier.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
