On Tue, Oct 02, 2012 at 08:54:28PM +0900, YAMANE Toshiaki wrote: > fixed some checkpatch below error. > -ERROR: Macros with complex values should be enclosed in parenthesis > > Signed-off-by: Toshiaki Yamane <yamaneto...@gmail.com> > --- > drivers/staging/rts_pstor/trace.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rts_pstor/trace.h > b/drivers/staging/rts_pstor/trace.h > index 740999c..a34493c 100644 > --- a/drivers/staging/rts_pstor/trace.h > +++ b/drivers/staging/rts_pstor/trace.h > @@ -78,8 +78,8 @@ do { > \ > goto label; > \ > } while (0) > #else > -#define TRACE_RET(chip, ret) return ret > -#define TRACE_GOTO(chip, label) goto label > +#define TRACE_RET(chip, ret) return(ret) > +#define TRACE_GOTO(chip, label) goto(label)
This will cause a compile error. There is no need to do this, checkpatch.pl is wrong here. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/