On Tue, 2 Oct 2012 18:36:42 +0200, Arnd Bergmann <[email protected]> wrote: > Calling kstrtoul requires checking the result. In case of > the viper_tpm_setup function, let's fail the __setup function > if the number was invalid. > > Without this patch, building viper_defconfig results in: > > arch/arm/mach-pxa/viper.c: In function 'viper_tpm_setup': > arch/arm/mach-pxa/viper.c:771:10: warning: ignoring return value of > 'kstrtoul', declared with attribute warn_unused_result [-Wunused-result] > > Signed-off-by: Arnd Bergmann <[email protected]> > Cc: Haojian Zhuang <[email protected]> > Cc: Eric Miao <[email protected]> > Cc: Marc Zyngier <[email protected]>
Acked-by: Marc Zyngier <[email protected]> > --- > arch/arm/mach-pxa/viper.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/mach-pxa/viper.c b/arch/arm/mach-pxa/viper.c > index 130379f..ac733e9 100644 > --- a/arch/arm/mach-pxa/viper.c > +++ b/arch/arm/mach-pxa/viper.c > @@ -768,8 +768,7 @@ static unsigned long viper_tpm; > > static int __init viper_tpm_setup(char *str) > { > - strict_strtoul(str, 10, &viper_tpm); > - return 1; > + return strict_strtoul(str, 10, &viper_tpm) >= 0; > } > > __setup("tpm=", viper_tpm_setup); -- Who you jivin' with that Cosmik Debris? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
