On Mon, Oct 08, 2012 at 08:41:36AM +0800, Wei Yongjun wrote: > From: Wei Yongjun <[email protected]> > > The dereference should be moved below the NULL test. > > dpatch engine is used to auto generate this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun <[email protected]> > --- > drivers/misc/ti-st/st_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c > index 46937b1..ee341ea 100644 > --- a/drivers/misc/ti-st/st_core.c > +++ b/drivers/misc/ti-st/st_core.c > @@ -511,13 +511,14 @@ long st_register(struct st_proto_s *new_proto) > unsigned long flags = 0; > > st_kim_ref(&st_gdata, 0); > - pr_info("%s(%d) ", __func__, new_proto->chnl_id); > if (st_gdata == NULL || new_proto == NULL || new_proto->recv == NULL > || new_proto->reg_complete_cb == NULL) { > pr_err("gdata/new_proto/recv or reg_complete_cb not ready"); > return -EINVAL; > } > > + pr_info("%s(%d) ", __func__, new_proto->chnl_id);
Why print this at all? Can't you just drop it now? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
