>> -----Original Message----- >> From: Nori, Sekhar >> Sent: Wednesday, October 10, 2012 8:46 AM >> To: Nori, Sekhar >> Cc: Karicheri, Muralidharan; Hilman, Kevin; davinci-linux-open- >> sou...@linux.davincidsp.com; mturque...@linaro.org; >> linux-c6x-...@linux-c6x.org; >> a...@arndb.de; linus.wall...@linaro.org; linux-kernel@vger.kernel.org; >> rob.herr...@calxeda.com; linux-keyst...@list.ti.com - Linux developers for >> Keystone >> family of devices (May contain non-TIers); viresh.li...@gmail.com; >> li...@arm.linux.org.uk; a...@linux-foundation.org; shawn....@linaro.org; >> linux-arm- >> ker...@lists.infradead.org >> Subject: Re: [PATCH 02/13] clk: davinci - add PSC clock driver >> >> On 10/10/2012 6:05 PM, Sekhar Nori wrote: >> >> >> +struct clk *clk_register_davinci_psc(struct device *dev, const char >> >> *name, >> >> + const char *parent_name, >> >> + struct clk_davinci_psc_data *psc_data, >> >> + spinlock_t *lock) >> > >> > Why do you need the lock to be provided from outside of this file? You >> > can initialize a lock for serializing writes to PSC registers within >> > this file, no? >> >> Looking again, it seems like the common clock framework defines an >> "enable_lock" in >> drivers/clk/clk.c to serialize the clock enable/disable calls. Unless I am >> missing something, >> this lock seems unnecessary. >>
I think you are right. For enable() api, enable_lock is sufficient and I will remove this. >> Thanks, >> Sekhar
