>> -----Original Message-----
>> From: Nori, Sekhar
>> Sent: Thursday, October 11, 2012 6:35 AM
>> To: Nori, Sekhar
>> Cc: Karicheri, Muralidharan; Hilman, Kevin; davinci-linux-open-
>> sou...@linux.davincidsp.com; mturque...@linaro.org;
>> linux-c6x-...@linux-c6x.org;
>> a...@arndb.de; linus.wall...@linaro.org; linux-kernel@vger.kernel.org;
>> rob.herr...@calxeda.com; linux-keyst...@list.ti.com - Linux developers for
>> Keystone
>> family of devices (May contain non-TIers); viresh.li...@gmail.com;
>> li...@arm.linux.org.uk; a...@linux-foundation.org; shawn....@linaro.org;
>> linux-arm-
>> ker...@lists.infradead.org
>> Subject: Re: [PATCH 01/13] clk: davinci - add Main PLL clock driver
>>
>> On 10/10/2012 5:32 PM, Sekhar Nori wrote:
>> > Hi Murali,
>> >
>> > On 9/26/2012 11:37 PM, Murali Karicheri wrote:
>> >> This is the driver for the main PLL clock hardware found on DM SoCs.
>> >> This driver borrowed code from arch/arm/mach-davinci/clock.c and
>> >> implemented the driver as per common clock provider API. The main PLL
>> >> hardware typically has a multiplier, a pre-divider and a post-divider.
>> >> Some of the SoCs has the divider fixed meaning they can not be
>> >> configured through a register. HAS_PREDIV and HAS_POSTDIV flags are
>> >> used to tell the driver if a hardware has these dividers present or not.
>> >> Driver is configured through the structure clk_davinci_pll_data that
>> >> has the platform data for the driver.
>> >>
>> >> Signed-off-by: Murali Karicheri <m-kariche...@ti.com>
>> >
>> > Are you using git-format-patch to generate the patches? It should have
>> > added a diffstat here by default which is very useful in quickly
>> > understanding what the patch is touching.
>> >>
>> >> diff --git a/drivers/clk/davinci/clk-davinci-pll.c
>> >> b/drivers/clk/davinci/clk-davinci-pll.c
>>
>> Looking at how common clock framework for mxs has been implemented, this
>> file should
>> simply be clk-pll.c. That makes sense as you are creating a davinci folder
>> anyway. Similar
>> change required for psc as well.
>>
Alternately, do we need a davinci folder? Can't we just add it to the clk/
directory? These IPs are re-used in c6x and keystone architectures. So it make
sense to keep in the clk folder. If agree, I can make this change in v3.
>> Thanks,
>> Sekhar
N�����r��y����b�X��ǧv�^�){.n�+����{����zX����ܨ}���Ơz�&j:+v�������zZ+��+zf���h���~����i���z� �w���?�����&�)ߢf��^jǫy�m��@A�a���
0��h���i
