On Fri, Oct 12, 2012 at 1:36 PM, viresh kumar <viresh.ku...@linaro.org> wrote: > On Fri, Oct 12, 2012 at 1:53 PM, Andy Shevchenko > <andriy.shevche...@linux.intel.com> wrote: >> On Fri, 2012-10-12 at 11:14 +0530, Viresh Kumar wrote: > >>> + while (++i < dw->sd_count) { >>> + if (!strcmp(dw->sd[i].bus_id, param)) { >>> + found = 1; >>> + break; >>> + } >>> + } >>> + >>> + if (!found) { >>> + last_dw = dw; >>> + last_bus_id = param; >>> + return false; >> Because of return here you could eliminate 'found' flag at all. > how?
while (++i < dw->sd_count) { if (!strcmp(dw->sd[i].bus_id, param)) { chan->private = &dw->sd[i]; last_dw = NULL; last_bus_id = NULL; return true; } } last_dw = dw; last_bus_id = param; return false; -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/