2012/10/15 Oleg Nesterov <[email protected]>: > On 10/14, Rabin Vincent wrote: >> Flush the cache so that the instructions written to the XOL area are >> visible. >> >> Signed-off-by: Rabin Vincent <[email protected]> >> --- >> kernel/events/uprobes.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c >> index ca000a9..8c52f93 100644 >> --- a/kernel/events/uprobes.c >> +++ b/kernel/events/uprobes.c >> @@ -1246,6 +1246,7 @@ static unsigned long xol_get_insn_slot(struct uprobe >> *uprobe, unsigned long slot >> offset = current->utask->xol_vaddr & ~PAGE_MASK; >> vaddr = kmap_atomic(area->page); >> arch_uprobe_xol_copy(&uprobe->arch, vaddr + offset); >> + flush_dcache_page(area->page); >> kunmap_atomic(vaddr); > > I agree... but why under kmap_atomic?
No real reason; I'll move it to after the unmap. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
