Hello, Dan. On Thu, Oct 18, 2012 at 04:00:03PM -0700, Dan Magenheimer wrote: > Forgive me if I am missing something, but it appears > that your commit: 57b30ae77bf00d2318df711ef9a4d2a9be0a3a2a > (workqueue: reimplement cancel_delayed_work() using try_to_grab_pending()) > has subtly broken the semantics of the function. If > work was idle, according to the comment, it should > return false, correct? > > It appears that very few callsites check the return value, > but ramster does, as does ocfs2 from whence the code at the > ramster callsite was derived. They both decrement > a kref count based on the return value. > > I am still looking at try_to_grab_pending as I am not sure > if its semantics have also changed. > > Thanks, > Dan > > Signed-off-by: Dan Magenheimer <[email protected]> > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index d951daa..042d221 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -2982,7 +2982,7 @@ bool cancel_delayed_work(struct delayed_work *dwork) > > set_work_cpu_and_clear_pending(&dwork->work, work_cpu(&dwork->work)); > local_irq_restore(flags); > - return true; > + return ret;
Ah, you're right. Applying to wq/for-3.7-fixes w/ patch description updated. Thanks! -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
