On 10/24/2012 04:08 PM, Andrew Lunn wrote:
> On Wed, Oct 24, 2012 at 03:49:21PM +0200, Gregory CLEMENT wrote:
>> From: Lior Amsalem <al...@marvell.com>
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clem...@free-electrons.com>
>> Signed-off-by: Lior Amsalem <al...@marvell.com>
>> ---
>> arch/arm/boot/dts/armada-370-db.dts | 3 +++
>> arch/arm/boot/dts/armada-370-xp.dtsi | 10 ++++++++++
>> arch/arm/boot/dts/armada-xp-db.dts | 3 +++
>> arch/arm/configs/mvebu_defconfig | 7 +++++++
>> 4 files changed, 23 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/armada-370-db.dts
>> b/arch/arm/boot/dts/armada-370-db.dts
>> index 4a31b03..2a2aa75 100644
>> --- a/arch/arm/boot/dts/armada-370-db.dts
>> +++ b/arch/arm/boot/dts/armada-370-db.dts
>> @@ -34,5 +34,8 @@
>> clock-frequency = <200000000>;
>> status = "okay";
>> };
>> + sata@d00a0000 {
>> + status = "okay";
>> + };
>> };
>> };
>> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi
>> b/arch/arm/boot/dts/armada-370-xp.dtsi
>> index 94b4b9e..3f08233 100644
>> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
>> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
>> @@ -69,6 +69,16 @@
>> compatible = "marvell,armada-addr-decoding-controller";
>> reg = <0xd0020000 0x258>;
>> };
>> +
>> + sata@d00a0000 {
>> + compatible = "marvell,orion-sata";
>> + reg = <0xd00a0000 0x2400>;
>> + interrupts = <55>;
>> + nr-ports = <2>;
>> + clocks = <&coreclk 0>;//, <&coreclk 0>;
>> + status = "disabled";
>> + };
>> +
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/armada-xp-db.dts
>> b/arch/arm/boot/dts/armada-xp-db.dts
>> index b1fc728..b0db9a3 100644
>> --- a/arch/arm/boot/dts/armada-xp-db.dts
>> +++ b/arch/arm/boot/dts/armada-xp-db.dts
>> @@ -46,5 +46,8 @@
>> clock-frequency = <250000000>;
>> status = "okay";
>> };
>> + sata@d00a0000 {
>> + status = "okay";
>> + };
>> };
>> };
>
> Hi Gregory
>
> Should there be some pinctrl setup somewhere, to ensure the pins used
> for SATA are really setup up for SATA?
Yes you're right we should not depend of the bootloader configuration.
>
> Also, for kirkwood, the number of SATA ports varies. So we don't
> define it in the base kirkwood.dtsi and leave each board to set it.
> Do we want to be consistent between kirkwood and 370/xp?
Yes sure. I will move it from dtsi to dts.
>
> Thanks
> Andrew
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
