On Fri, Oct 26, 2012 at 10:32 AM, Linus Torvalds <torva...@linux-foundation.org> wrote: > > Please just make "fw_path[0]" just be the pointer to fw_path_para[] > (which sounds like the cleanest fix) and get rid of the negative 'i' > and conditional entirely.
Yes, it should be the cleanest, I don't do it because I thought that might have caused one compile warning('const char *' points to memory without 'const', like below) static char fw_path_para[256]; static const char *fw_path[] = { fw_path_para, "/lib/firmware/updates/" UTS_RELEASE, "/lib/firmware/updates", "/lib/firmware/" UTS_RELEASE, "/lib/firmware" }; but in fact there isn't any warning with above change and it does work, still don't know why? :-( Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/