On Thu, 2012-10-25 at 17:05 -0700, Greg Kroah-Hartman wrote: > 3.6-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Kees Cook <keesc...@chromium.org> > > commit 31fd84b95eb211d5db460a1dda85e004800a7b52 upstream. > > The min/max call needed to have explicit types on some architectures > (e.g. mn10300). Use clamp_t instead to avoid the warning: > > kernel/sys.c: In function 'override_release': > kernel/sys.c:1287:10: warning: comparison of distinct pointer types lacks a > cast [enabled by default]
While this change makes the code more readable, I think the bug is really in the type definitions for those architectures: [...] > - copy = min(sizeof(buf), max_t(size_t, 1, len)); > + copy = clamp_t(size_t, len, 1, sizeof(buf)); [...] 1. sizeof(buf) yields a value of type size_t, by definition. 2. max_t(size_t, 1, len) yields a value of type size_t. 3. Therefore min(sizeof(buf), max_t(size_t, 1, len)) is valid. The only way I see to get this warning is to define size_t wrongly, so that (1) is not true. Ben. -- Ben Hutchings Never attribute to conspiracy what can adequately be explained by stupidity.
signature.asc
Description: This is a digitally signed message part
