From: Namhyung Kim <[email protected]>

When perf detects no libelf during the build, it'll use internal mini
elf parser instead of libelf.  But as it only supports minimal
functionalities, it also disables support to 'probe' builtin command.

Currently it didn't warned to user.  Fix it.

$ sudo apt-get remove libelf-dev
$ make
    CHK -fstack-protector-all
    CHK -Wstack-protector
    CHK -Wvolatile-register-var
    CHK bionic
    CHK libelf
    CHK glibc
Makefile:491: No libelf found, disables 'probe' tool, please install 
elfutils-libelf-devel/libelf-dev
    CHK libunwind
    CHK libaudit

$ make NO_LIBELF=1
    CHK -fstack-protector-all
    CHK -Wstack-protector
    CHK -Wvolatile-register-var
    CHK bionic
    CHK libaudit

Reported-by: Peter Zijlstra <[email protected]>
Signed-off-by: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/n/[email protected]
[ committer note: The package needed is elfutils-libelf-devel, not 
elfutils-devel ]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/Makefile |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 7e25f59..b1801e0 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -490,6 +490,8 @@ ifneq ($(call 
try-cc,$(SOURCE_LIBELF),$(FLAGS_LIBELF),libelf),y)
                LIBC_SUPPORT := 1
        endif
        ifeq ($(LIBC_SUPPORT),1)
+               msg := $(warning No libelf found, disables 'probe' tool, please 
install elfutils-libelf-devel/libelf-dev);
+
                NO_LIBELF := 1
                NO_DWARF := 1
                NO_DEMANGLE := 1
-- 
1.7.9.2.358.g22243

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to