On Thursday 01 November 2012 22:29:43 Alan Cox wrote: > On Thu, 1 Nov 2012 21:55:54 +0100 > > Ondrej Zary <[email protected]> wrote: > > pm_whitelist breaks suspend on all non-whitelisted cards for unknown > > purpose. Remove it. This fixes suspend on Terratec DMX and SF64-PCE2 > > cards. > > Because lots of them broke laptops. > > Why not just whitelist the ones you know works, given there are ones we > know doesn't so your patch is an instant regression guarantee ? > > (and yes a blacklist might have been brighter but I don't know the > history and it's a bit late to fix)
I wonder what does the suspend/resume code break? Currently, all non-whitelisted cards are broken (not working after resume). The problem with adding cards to the whitelist is that Terratec DMX has generic subsystem ID: ESS Technology ES1978 Maestro 2E [125d:1978] (rev 10) Subsystem: ESS Technology ES1978 Maestro 2E [125d:1978] Adding this to the whitelist does not look like a good idea... -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
