> > >> Hi Yinghai, > > >> > > >> Per the following thread, the code seems to be written in this way to > > >> allocate a separate lock_class_key for each work queue. It should have > > >> had some comment to explain this, though. > > >> > > >> https://lkml.org/lkml/2009/12/13/304 > > > > > > The code has evolved since then, however, so that it doesn't make sense > > > any more. > > > > > > > oh, no, that commit should not be reverted. instead we should add some > > comment for it... > > > > that mean : three path, will have three separated static lock dep key > > from every INIT_WORK. > > I see. > > OK, I'll drop the patch removing it. > > What about the following comment: > > "To prevent lockdep from complaining unnecessarily, make sure that there > is a different static lockdep key created for each workqueue by using > INIT_WORK for each of them separately."
Looks good to me. Thanks, -Toshi > > Thanks, > Rafael > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
