On Mon, Nov 05, 2012 at 10:42:26PM +0000, Arnd Bergmann wrote: > On Monday 05 November 2012, Rob Herring wrote: > > But this should work: > > > > if (!handle_arch_irq) > > handle_arch_irq = fpga_handle_irq; > > > > As long as the primary controller is always initialized first, this will > > work. This is guaranteed by DT of_irq_init, and you will probably have > > other problems if that wasn't the case for non-DT. > > How about adding a top-level function in arch/arm that does the assignment > and hides the handle_arch_irq variable: > > void set_handle_irq(void (*handle_irq)(struct pt_regs *)) > { > if (WARN_ON(handle_arch_irq)) > return; > > handle_arch_irq = handle_irq; > } > EXPORT_SYMBOL_GPL(set_handle_irq); > > Hmm, maybe putting the top-level handler into a loadable module is a bit > far-fetched, but one can hope ;-)
Definitely no point in exporting this (never export a symbol unless you really want to use it from a module) - if you don't already have something in handle_arch_irq, you're not going to get anywhere near the module loader. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/